-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MoM] Add Torrential Channeling, revamp Extended Channeling #74007
Merged
Maleclypse
merged 17 commits into
CleverRaven:master
from
Standing-Storm:channeling-traits
May 24, 2024
Merged
[MoM] Add Torrential Channeling, revamp Extended Channeling #74007
Maleclypse
merged 17 commits into
CleverRaven:master
from
Standing-Storm:channeling-traits
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
EOC: Effects On Condition
Anything concerning Effects On Condition
Mods: Mind Over Matter
astyled
astyled PR, label is assigned by github actions
labels
May 22, 2024
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
May 23, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
May 23, 2024
…se many powers in quick succession
data/mods/MindOverMatter/effectoncondition/eoc_nether_attunement_events.json
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
json-styled
JSON lint passed, label assigned by github actions
label
May 23, 2024
github-actions
bot
added
BasicBuildPassed
This PR builds correctly, label assigned by github actions
and removed
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
May 23, 2024
data/mods/MindOverMatter/effectoncondition/eoc_nether_attunement_events.json
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
May 23, 2024
…nt_events.json Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
EOC: Effects On Condition
Anything concerning Effects On Condition
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: Mind Over Matter
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[MoM] Add Torrential Channeling, revamp Extended Channeling"
Purpose of change
Extended Channeling has been in kind of a weird place since I revamped the channeling success formula for psionic powers. It used to be a way to ensure success for powers with a high fail chance, but now fail chance if you have good skill and no pain is pretty close to zero, so it needs a new niche. And just like there's a way to be more careful when channeling, there should be a way to be more reckless if you need more power.
Describe the solution
Add the Torrential Channeling trait, with a recipe to discover it unlocked at Metaphysics 6. Torrential Channeling and Extended channeling now do the following:
Torrential Channeling:
Extended Channeling:
You cannot have both active at once (activating one automatically turns the other off, if it's active)
Describe alternatives you've considered
Testing
Traits work as advertised. Torrential channeling is autolearnable and can be unlocked. Activating one trait deactivates the other (if active).
Additional context