Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added roof on airport ATC tower #74000

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

PatrikLundell
Copy link
Contributor

@PatrikLundell PatrikLundell commented May 22, 2024

Summary

None

Purpose of change

Ensure the private airport doesn't rely on roof adding magic, but rather defines all its roofs explicitly.

Describe the solution

Define another Z level with a roof for the tower and hook it into the infrastructure.

Describe alternatives you've considered

Testing

  • Hack map.cpp operation map::add_roofs to return immediately to disable the roof adding magic.
  • Debug spawn the airport special.
  • Teleport to it and climb the tower.
  • Teleport up onto the roof.
  • Enjoy the view (and verify the roof does exist and the buildings below have their roofs too.
  • Restore the code.

Screenshot (374)

Additional context

This is part of a long term effort to try to get rid of the usage of magic to create roofs (as well as getting rid of said magic creating roofs where there those roofs should be gone/nonexistent). Only trees should be allowed to be subjected to magic (unless a good way not to rely on magic is found).
The abandoned textile mill looks quite reasonable without magic roofs, by the way.

It can also be noted that the ATC tower can't be constructed by players, as the construction rules don't allow for any overhangs. Since these things exist in real life, the construction rules ought to change eventually.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 22, 2024
@dseguin dseguin merged commit 1c4d7c1 into CleverRaven:master May 22, 2024
27 checks passed
@PatrikLundell PatrikLundell deleted the airport branch May 22, 2024 19:47
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants