Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit roof on storehouse 1 #73998

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

PatrikLundell
Copy link
Contributor

@PatrikLundell PatrikLundell commented May 22, 2024

Summary

None

Purpose of change

Give basecamp expansion storehouse version 1 roof explicitly rather than relying on magic.

Describe the solution

Same as previous cases, extend palettes, add roofs based on the ground floor, and make use of the roofs and 3D coordinates.

Describe alternatives you've considered

Testing

  • Loaded a suitable save.
  • Sent a companion to survey and then build each structural section. The first 8 in different materials to cover the material range.
  • Check that the results look as expected.
    Screenshot (372)

Screenshot (373)

Additional context

The expansion to the south was created due to autosave, and the construction on it due to construction in the wrong expansion (but the material was used for a "real" segment as well).

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Crafting / Construction / Recipes Includes: Uncrafting / Disassembling json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 22, 2024
@Maleclypse Maleclypse merged commit 3b3b739 into CleverRaven:master May 23, 2024
28 checks passed
@PatrikLundell PatrikLundell deleted the storehouse1 branch May 23, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants