Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New issue dialogue: remove discussions, two more resources #73996

Merged
merged 1 commit into from
May 22, 2024

Conversation

NetSysFire
Copy link
Member

Summary

None

Purpose of change

  1. We have github discussions disabled for non-collaborators since ages.
  2. Point out that typos and stuff for translations go somewhere else since they arent managed in this repo. I hope "non-technical" is clear enough that actual errors with e.g extracting strings are in need of a bug report here.
  3. As much as I respect people hunting for typos, it really is faster fixing them than actually enumerating and reporting them one by one. This links to github docs which details how to edit files in the web UI. I have used it myself many times and I am exceptionally insecure when it comes to new stuff but I managed to create my very first PR some years ago with just this.

Describe the solution

Describe alternatives you've considered

Maybe an actual "I found typos, give me a guide" guide featuring mentions to the manual of style, what typos not to fix (e.g monster and item IDs). Maybe that can be put into the built-in wiki in this repo.

Testing

Theres no error displayed when I view that file directly so I hope it will render just fine. YAML can be a bit tricky when it comes to special characters.

Additional context

@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 22, 2024
@Hyperseeker
Copy link
Contributor

I'm curious to see how many typos get fixed by (previous) non-collaborators after this PR is merged. (Ideally, this would be compared to previous typo PRs over the same period of time.) Is there any way to view or provide statistics for this sort of thing with Github alone?

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 22, 2024
@dseguin dseguin merged commit 8bf5502 into CleverRaven:master May 22, 2024
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants