Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR] Bionic multimeter #73992

Merged
merged 3 commits into from
May 27, 2024
Merged

Conversation

natsirt721
Copy link
Contributor

@natsirt721 natsirt721 commented May 21, 2024

Summary

Features "Add bionic multimeter and bench electronics kit"

Purpose of change

#73889 calls for low and medium power bionics: I deliver two.

The first is a simple 'integrated multimeter'. Electrical leads in the fingertips attached to a readout on the back of your hand or wrist or something. Touch two points to read current/voltage/resistance. I can imagine the character doing a 👌 to read the current inline :)

The second is an upgrade of the first, which adds a soldering iron and a screwdriver. The idea is that a professional electronics repairman would have all the things he needs at his fingertips (ha ha). I would prefer to just add fine screwdriving, but most of the electronics crafting recipes require the regular screwdriving quality, so this bionic provides both. There's a case to be made for adding fine cutting or fine bolt turning (and probably others) - but frankly I don't have much electronics repair experience so I don't know how useful those things would be.

I figure since the system is designed to conduct electricity without interfering with the user's nervous system that you'd also get a bit of protection from electrical damage for your hands and arms. I have no sense of scale but 3 seemed like a nice number to start with.

Practically, I feel these are simpler and less useful than the integrated multitool, so their prices and difficulty are based on that bionic.

Describe the solution

Added new bionics, CBM items, and pseudoitems. Updated soldering itemgroup with soldering iron, and ad-hoc soldering iron recipes where appropriate. Updated bionics item groups and exodii trading groups with new CBM items.

Describe alternatives you've considered

I chose not to make these conflict with the integrated toolset bionic, but they are doing similar things in a similar place, and I won't die on that hill.

Testing

Debug-installed bionics and checked recipes to ensure everything is working as intended.

Additional context

none

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Bionics CBM (Compact Bionic Modules) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Spawn Creatures, items, vehicles, locations appearing on map Items: Armor / Clothing Armor and clothing <Enhancement / Feature> New features, or enhancements on existing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 21, 2024
@natsirt721 natsirt721 changed the title Bionic multimeter [CR] Bionic multimeter May 22, 2024
@natsirt721 natsirt721 force-pushed the bionic-multimeter branch from 941b8b6 to a256e1a Compare May 22, 2024 00:12
@github-actions github-actions bot added Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` labels May 24, 2024
@natsirt721
Copy link
Contributor Author

Not sure why the hazmat test is failing. Somehow 'the beak' is getting into the list of bodyparts the hazmat suit covers. Which - sure, but I'm not touching any of that.

@RenechCDDA
Copy link
Member

Not sure why the hazmat test is failing. Somehow 'the beak' is getting into the list of bodyparts the hazmat suit covers. Which - sure, but I'm not touching any of that.

The (other) iteminfo test is checking the description of the hazmat suit, including what can repair it. You added a new item which can repair it, but the test does not know that. You will need to update the test's expected description to include your added "integrated soldering iron".

@natsirt721
Copy link
Contributor Author

The (other) iteminfo test is checking the description of the hazmat suit, including what can repair it.

Hmm, I updated the test but I put it in the wrong place. Its putting the integrated soldering iron at the front of the list with the welders instead of with the other soldering irons. Doesn't seem great but it doesn't look like I can specify the order anywhere?

@natsirt721
Copy link
Contributor Author

natsirt721 commented May 26, 2024

The one I don't understand is this one:
image
how is Beak getting in there?

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 26, 2024
@Maleclypse Maleclypse merged commit 459ec63 into CleverRaven:master May 27, 2024
21 of 27 checks passed
@Maleclypse
Copy link
Member

That's a test that we know fails because of something someone did with colors that they haven't been able to come back and fix. It doesn't actually break the game so we've left it in for them to fix at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Enhancement / Feature> New features, or enhancements on existing Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants