Increase the size of the set of clothes pocket #73991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the set of clothes is limited to only 100 L and 100 kg, issues may easily arise when wearing a lot of objects with lots of volume among them, which has the potential to not let everything being worn be inserted into the set of clothes, and potential loss of items when the input volume or weight is larger than the limit during json verification on save loading was bad.
github-actions
bot
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
When the set of clothes is limited to only 100 L and 100 kg, issues may easily arise when wearing a lot of objects with lots of volume among them, which has the potential to not let everything being worn be inserted into the set of clothes, and potential loss of items when the input volume or weight is larger than the limit during json verification on save loading was bad.
Describe the solution
Increase both the volume and weight capacity of the set of clothes to 1000 L and 1000 kg respectively, as suggested by Renech on the discord.
Describe alternatives you've considered
Changing the volume and size by less, leaving both as they are.
Testing
Increasing the volume and mass capacity stops errors from being called in the instances where I had an issue with it.
Additional context