Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new locations to Aftershock #73988

Merged

Conversation

QuillInkwell
Copy link
Contributor

@QuillInkwell QuillInkwell commented May 21, 2024

Summary

Content "Add three new locations to Aftershock"

Purpose of change

There is currently a limited amount of variety to the locations you can visit in the Aftershock Exoplanet mod. This PR is the first of several that aim to expand the number of locations you can find while on the Exoplanet.

Describe the solution

This PR adds three new locations to Aftershock as well as new some new furniture and terrains for use in them:
The Shuttlepad is a fenced in landing platform with a small Space-port control building attached. The landing platform has little of interest. However the Spaceport terminal has some scrapable furniture. The racks might also spawn useful hardware. The Sealed Intermodal crates can be cracked open with oxy-torch. They contain a decent amount of random civilian loot, usually food, rarely medicine or guns. The Shuttle Landing Pad spawns quite rarely so it will usually only be found is bigger cities. Moxies can spawn on the landing platform and a skitter bot will always spawn in the spaceport terminal. The Lights in the building have a 20% chance of being active on generation.
image_2024-05-22_114329673

The Malamute Freight Transport is a wreck of large treaded vehicle too massive to be restored. It's intended as a large snow crawler used for expeditions out on the icy wastes. The rear of the vehicle is dedicated to crew living quarters and can be accessed through the rear exhaust ventilations. The Midsection of the craft is is cargo bay with many racks and sealed crates. The crafts reactor is also located here locked behind a computer access terminal. Beyond that is the airlock which contains lockers for extreme climate survival. Moxies tend to spawn around this area on both sides which can make this approach difficult. Low threat robots can spawn anywhere inside the craft. The fore section of the craft is dedicated to a fabrication bay, bridge, and armory. The Fabrication bay has many useful furniture's for scrapping. The Armory is locked behind another computer access terminal. Inside Civilian guns and a worker exosuit (standard, not light) can be found. The hulls of the craft is composed of reinforced glass and metal walls. The malamute always spawns with lights on since it is implied from the working computer terminals that it still has power.
image_2024-05-22_114203021

The General store is a live in connivence store that stocks a modest variety of goods. Old food, consumer electronics, small tools, magazines, frontier cryosuits, and (rarely)structural repair equipment can all be found on the sales floor. Similiar loot is also stocked in the storeroom. UICA chits can spawn in the cash register and office safe. The Register is sometimes looted while the safe always contains goodies. There is an ATM on the ground floor as is typical for modern convivence stores. (However I can remove this if there are other plans for ATM spawns.) Upstairs features modest 2 bedroom accommodations with home loot spawns. There is also a utility room with habitat life support on the second floor. Both floors have lights that have an 20% chance of being active on generation. This Chance is checked once per floor.
image_2024-05-22_113442006
image_2024-05-22_113505270

Terrains:
Broken vehicle treads added for use in the Malamute. Mostly copies the stats and loot table of civ spaceship hull with some reductions in loot and durability.

Inactive Metal Floor Light added for use in Aftershock buildings. It serves as a marker to be replaced with it's active light emitting version during ter_fur_transforms. This is done in anticipation of being able to turn on and off buildings lights using the yet unimplemented hacking mechanic.

Furniture:
Open and Sealed Intermodal Crates. Sealed crates can be opened with an oxy torch to get at the loot inside. Item group for sealed crates added which mostly contains civilians goods in moderate to good amounts.

Describe alternatives you've considered

I really wanted to make it so you could also hack Sealed crates as a way to open them. However all the methods of hacking are hardcoded into ways that simply wouldn't work for my purposes. In the future I may look into using an EOC to maybe somehow create a hacking mechanic.

I currently achieve turning on lights by spawning nested mapgen which executes a ter_fur_transform on the entire map tile based on a percentage chance. This execution works for single floor, single tile buildings. But breaks down on multi-tile, multi-floor buildings. I assume you can't have a single nested mapgen operate on multiple floors and tiles at once. So each tile re-rolls the chance for nested mapgen being placed. Currently this isn't much of a problem. But I have considered just not spawning the active light versions at all until I come up with a better method. One that allows for the whole building to be lights on or lights off.

Testing

Spawned the structures in manually as well as verified their natural spawning on generated Exoplanet world. Performed some limited balance testing to verify loot spawns "felt" good. Would always appreciate further balancing from more experienced community members in future.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mods: Aftershock Anything to do with the Aftershock mod labels May 21, 2024
data/mods/Aftershock/maps/city_buildings.json Outdated Show resolved Hide resolved
data/mods/Aftershock/maps/city_buildings.json Outdated Show resolved Hide resolved
data/mods/Aftershock/maps/mapgen/shuttle_pad.json Outdated Show resolved Hide resolved
data/mods/Aftershock/maps/overmap_specials.json Outdated Show resolved Hide resolved
data/mods/Aftershock/maps/overmap_terrain.json Outdated Show resolved Hide resolved
data/mods/Aftershock/maps/overmap_terrain.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label May 21, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A sealed metal crate used to ferry cargo to and from orbit. This one appears to be secured with an electic lock.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label May 21, 2024
@Maleclypse
Copy link
Member

Look at the electronic lock eoc in Xedra Evolved. Substitute computers for deduction and bob’s your uncle.

@github-actions github-actions bot added the Items: Food / Vitamins Comestibles and drinks label May 22, 2024
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label May 22, 2024
@QuillInkwell QuillInkwell marked this pull request as draft May 22, 2024 02:52
@QuillInkwell QuillInkwell changed the title Quill aftershock mapgen Add new locations to Aftershock May 22, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label May 22, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 22, 2024
@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 22, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 22, 2024
@QuillInkwell
Copy link
Contributor Author

Look at the electronic lock eoc in Xedra Evolved. Substitute computers for deduction and bob’s your uncle.

Candlebury told to me let them know once I have crates on the maps so I imagine they have something in mind already. So I won't be adding hacking the crates to this PR. But I did have a look at the EOC anyway and it's pretty neat. I personally was too hung up on hacking tools and consuming charge I never considered just doing without a tool entirely.

@QuillInkwell QuillInkwell marked this pull request as ready for review May 22, 2024 18:06
@John-Candlebury John-Candlebury merged commit 2d02175 into CleverRaven:master May 23, 2024
20 of 24 checks passed
@John-Candlebury
Copy link
Member

Really cool stuff. Thanks!

@QuillInkwell QuillInkwell deleted the quill_aftershock_mapgen branch May 23, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants