Added explicit roof to garage 1 #73983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Add explicit roof to garage expansion version 1 rather than relying on magic.
Describe the solution
Add roof chunks to complement the floor ones and use them.
Also updated the flags to get rid of flowers and boulders inside and error messages about those.
Describe alternatives you've considered
Keep the expansion look exactly as before, with varying kinds of roofs depending on the roof elements of the constructed components. Went with uniform shingle roof instead.
Testing
The boulder in the wall isn't real, but rather the fairly recently introduced selective map amnesia.
Additional context
Did not experience sudden companion based glutton death this time, despite having to run the tests twice (screwed up by failing to convert floor to roof for a couple of tiles when generating the roof layouts). Assume that weird thing was a fluke.