Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize tolerance messages #73970

Merged
merged 6 commits into from
May 22, 2024
Merged

Standardize tolerance messages #73970

merged 6 commits into from
May 22, 2024

Conversation

TealcOneill
Copy link
Contributor

@TealcOneill TealcOneill commented May 20, 2024

Summary

None

Purpose of change

Closes #73909

Describe the solution

Standardizes the language used for heat and cold tolerances and fixes a typo.

Describe alternatives you've considered

Testing

Changed the text, loaded up and checked it in game including giving myself the mutation and seeing that the game didn't crash and burn.

Additional context

Standardizes the language used for heat and cold tolerances and fixes a typo.
Copy link
Contributor

You are creating a pull request with the master branch as the head branch. This is likely a mistake unless you really know what you are doing. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 20, 2024
@Procyonae
Copy link
Contributor

You've sided with the less clear of the two imo

@TealcOneill
Copy link
Contributor Author

The dealing with the consequences part just didn't feel right to me. How does this sound?
You fare better than most in warmer climates and are less bothered by hotter temperatures. Note that while it will take more heat and exposure for you to suffer the effects of sunstroke, you aren't any better at dealing with the symptoms.
You fare better than most in colder climates and are less bothered by lower temperatures. Note that while it will take more cold and exposure for you to suffer the effects of frostbite, you aren't any better at dealing with the symptoms.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 21, 2024
@Procyonae
Copy link
Contributor

Ye as long as the way it's mechanically working is clear idm how it's described

Adds newer version after discussion with Procyonae
@github-actions github-actions bot removed BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 22, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label May 22, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 22, 2024
@dseguin dseguin merged commit 6975cd4 into CleverRaven:master May 22, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typo
3 participants