Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fd_reality_tear back to fd_fatigue (fix tilesets, migration) #73958

Merged
merged 1 commit into from
May 21, 2024

Conversation

RenechCDDA
Copy link
Member

Summary

None

Purpose of change

fd_fatigue was renamed to fd_reality_tear in #72708, but we do not have any migration handling for fields. This causes existing instances of the field to throw errors on load and disappear (as a valid field cannot be found for them).

Additionally, because the ID has changed the tilesets no longer have an entry for them. This causes them to revert to their looks_like of smoke. The actual graphics are pretty cool, so I'd like to keep them.

Describe the solution

Revert this naming change.

Describe alternatives you've considered

Implement migration handling and figure out the tileset incantations to move its sprites around?

Testing

Load this save without the patch, notice field errors and no tears in reality exist on load:
FIELDS NAME-trimmed.tar.gz

(Without saving) Load after patch, notice fields exist and look like they should on all tiles builds with in-repo tilesets

Additional context

This causes the reverse problem for builds created between April 4th and the merging of this PR, in that fd_reality_tear generated in saves between them will disappear. This is not ideal, but the issue will not occur for anyone moving from 0.H--->a hypothetical future 0.I, which is desirable.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mods: Aftershock Anything to do with the Aftershock mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mechanics: Enchantments / Spells Enchantments and spells EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter labels May 20, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @LyleSY @Standing-Storm

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 20, 2024
@Procyonae Procyonae mentioned this pull request May 20, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 20, 2024
@I-am-Erk
Copy link
Member

I don't have strong opinions on this, and a revert is probably the right change for now given the knock on effects, but I think we need a mechanic to change these. It's relatively minor thing that fd_fatigue doesn't make sense as a name, but it's a problem when we have no mechanic to change an ID for any reason.

Also though I really dislike fd_fatigue, it's just one of those things that adds another element of nuisance to content addition/editing for no reason.

@I-am-Erk I-am-Erk merged commit 0ff35f8 into CleverRaven:master May 21, 2024
24 of 29 checks passed
@RenechCDDA RenechCDDA deleted the revert_field_ID_change branch May 21, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. EOC: Effects On Condition Anything concerning Effects On Condition Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mechanics: Enchantments / Spells Enchantments and spells Mods: Aftershock Anything to do with the Aftershock mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: Mind Over Matter Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants