Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bark (inherit upgrades & fix missability) #73944

Merged
merged 2 commits into from
May 21, 2024

Conversation

Kamejeir
Copy link
Contributor

Summary

None

Purpose of change

Getting shifting bark, then camouflage skin, getting certain addons (Leaves, Vines, Vine Limbs, Vine Sprouter, Transpiration and Flowering) would cause a downgrade of shifting bark. Since jaundice does not change into what the latter downgrades into (protective bark), the mutation system attempting to get jaundice would result in never being able to get shifting bark again.

Related to bark having troubles, shifting bark was not enjoying blister resist that its predecessor got.

Describe the solution

Add more prereqs to the afflicted mutations.

Replace the check of bark with a character flag (and add them to the bark variants), thanks Venera. (Yes, there is unseen conversation, this is a restart of #73912 that was borked up due to forking shenanigans.)

Describe alternatives you've considered

Testing

It just works. I say that in the confidence a toe-dipping level of test can give me.

It builds, the flag seems to work, and the prereqs produce the expected result.

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs labels May 19, 2024
src/character_body.cpp Outdated Show resolved Hide resolved
… watch over for..

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 19, 2024
@Maleclypse Maleclypse merged commit 8e6eac5 into CleverRaven:master May 21, 2024
23 of 27 checks passed
@Kamejeir Kamejeir deleted the barkedup branch May 21, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants