Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ski mask is now a tube scarf #73941

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

Kamejeir
Copy link
Contributor

Summary

Features "Ski mask has been sublimbed"

Purpose of change

The ski mask was not sufficiently sublimbed when I wanted to use it. The end result of my thoughts (and the help of Karol giving input, a Discord link) made it make the most sense as being remodeled into a tube scarf.

Some shenanigans with my fork made me restart this from #73855

Describe the solution

The ski mask in its original form is largely unchanged, made to work with a gas mask to avoid a regression. The warmth value on that form was changed to work more nicely with how the "open" form, now using sublimbs, reduce that warmth via using less total sublimb coverage.

The "open" form pretends to be worn around the neck, allowing dragging it over your mouth when wanting to avoid being struck with a chilling gust of wind while skiing downhill, for example. I thought that made sense, with that being the way I use mine.

Describe alternatives you've considered

Making this another item, but the wacky non-limbed mouth has been bothering me too much.

Testing

I give you my guarantee that all these things have been tested in regards to coverage, warmth, encumbrance values... I believe I've been thorough.

Additional context

I would change the material, but recipes are scary.

The specific sublimbs covered are based on me wearing my own tube scarf. Thin and flexible, it pairs well with ski goggles and a helmet to keep my face free from frost (while making sure it's secured and won't fold inadvertently).

I would love to make the sprite for the collar form something akin to a scarf, but I do not know how.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 19, 2024
@Maleclypse Maleclypse merged commit a81f340 into CleverRaven:master May 21, 2024
26 checks passed
@Kamejeir Kamejeir deleted the askiimask branch May 21, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Enhancement / Feature> New features, or enhancements on existing Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants