Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit roofs on canteen 1 #73905

Merged
merged 1 commit into from
May 19, 2024
Merged

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Add explicit roofs to expansion canteen 1, as well as chimneys/stove pipes on said roof.

Describe the solution

Use the 3D syntax to update the JSON files.

Describe alternatives you've considered

  • Change the metal material from junk to scrap metal (like most other cases use).

Testing

  • Created the whole construction of the expansion in 7 different materials, plus fireplaces and smoking racks.
  • Verified that the results looked correct.
  • Created the first section of it from the first material and added stoves.
  • Verified that those two pieces looked correct as well.

Screenshot (362)
Screenshot (363)
Screenshot (364)
Screenshot (365)

Additional context

  • Pruned the palette usages to only use the common one when elements from it were used.
  • Fixed an error report bug so I could see what I'd screwed up and fix that.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 18, 2024
@Maleclypse Maleclypse merged commit 2a40c38 into CleverRaven:master May 19, 2024
29 checks passed
@PatrikLundell PatrikLundell deleted the canteen1 branch May 19, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants