Don't try to get non-existent spellbook spells #73800
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Describe the solution
Don't bother accessing the player's spellbook or knowledge - just get the corresponding spell itself and return the translated name.
Add an additional bit of safety to known_magic::get_spell. It was returning a spell reference even if the reference was known to be bad. Return some dummy data instead. Trying to access the spellbook(std::map) that doesn't contain that requested key inserts that key into the map.
Describe alternatives you've considered
Testing
Additional context