-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Magiclysm] Update Forge of Wonders Dialogue Options #73791
[Magiclysm] Update Forge of Wonders Dialogue Options #73791
Conversation
There were repeats of mission options in places that didn't make sense, and mission dialogue and the mission-giving related to the orcs needed to be updated with the overhaul to goblins and orcs. With that, her characterization was made more consistent through her dialogue, and an rng roll was added to allow both wizard tower missions to be independently assigned, albeit randomly. fixes CleverRaven#73433, references CleverRaven#71758
None of the merchants in the Forge of Wonders previously had a dialogue option to update the player when their next restock should be, a QOL feature that was painfully missing. references CleverRaven#73434
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
<3 to the goblin-related dialogue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I like how the characters personalities are being extended meaningfully.
Ok that error was almost invisible. a bracket instead of a curlyque. |
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Summary
Mods "Update Diviner Missions and Forge Merchant Dialogue"
Purpose of change
None of the Forge of Wonders Merchants had dialogue indicating when their next restock is, and this resolves that (see #73434). In addition, the diviner at the forge of wonders had some references to places that were out of date (especially the Orc Encampment), closes #73433 .
Describe the solution
Edited the json using the pre-existing call for the restock dialogue options, and also edited the json dialogue of the diviner to make all the quest options do what they say they will do.
Describe alternatives you've considered
Leaving the dialogue as is and letting people remain confused as to what the options really mean in game.
Testing
No testing was done (I had issues with compiling it completely unrelated to the changes I made)
Additional context
None I think.