Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Update Forge of Wonders Dialogue Options #73791

Merged
merged 7 commits into from
May 20, 2024

Conversation

TheAthenaCabin0
Copy link
Contributor

Summary

Mods "Update Diviner Missions and Forge Merchant Dialogue"

Purpose of change

None of the Forge of Wonders Merchants had dialogue indicating when their next restock is, and this resolves that (see #73434). In addition, the diviner at the forge of wonders had some references to places that were out of date (especially the Orc Encampment), closes #73433 .

Describe the solution

Edited the json using the pre-existing call for the restock dialogue options, and also edited the json dialogue of the diviner to make all the quest options do what they say they will do.

Describe alternatives you've considered

Leaving the dialogue as is and letting people remain confused as to what the options really mean in game.

Testing

No testing was done (I had issues with compiling it completely unrelated to the changes I made)

Additional context

None I think.

There were repeats of mission options in places that didn't make sense,
and mission dialogue and the mission-giving related to the orcs needed
to be updated with the overhaul to goblins and orcs. With that, her
characterization was made more consistent through her dialogue, and an
rng roll was added to allow both wizard tower missions to be
independently assigned, albeit randomly.
fixes CleverRaven#73433, references CleverRaven#71758
None of the merchants in the Forge of Wonders previously had a dialogue
option to update the player when their next restock should be, a QOL
feature that was painfully missing.
references CleverRaven#73434
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Missions Quests and missions Mods: Magiclysm Anything to do with the Magiclysm mod new contributor labels May 14, 2024
@github-actions github-actions bot requested a review from KorGgenT May 14, 2024 23:26
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label May 14, 2024
@Standing-Storm
Copy link
Contributor

<3 to the goblin-related dialogue

Copy link
Member

@NetSysFire NetSysFire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like how the characters personalities are being extended meaningfully.

data/mods/Magiclysm/npc/TALK_FORGE_DIVINER.json Outdated Show resolved Hide resolved
@Maleclypse
Copy link
Member

Ok that error was almost invisible. a bracket instead of a curlyque.

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label May 17, 2024
data/mods/Magiclysm/npc/TALK_FORGE_ARDELIA.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/npc/TALK_FORGE_DIVINER.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/npc/TALK_FORGE_DIVINER.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/npc/TALK_FORGE_DIVINER.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/npc/TALK_FORGE_DIVINER.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/npc/TALK_FORGE_DIVINER.json Outdated Show resolved Hide resolved
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Good choice. It seems that shortly before the world started to end, a few of them got it in their heads to just leave civilization alone for a bit and go live in the woods with other goblins. And wargs. Not a terrible idea if you ask me. Anyways, theres a few different types of places they gather, are you looking for an encampment or an outpost?

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

data/mods/Magiclysm/npc/TALK_FORGE_DIVINER.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/npc/TALK_FORGE_DIVINER.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/npc/TALK_FORGE_HELEN_TAVREL.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/npc/TALK_FORGE_HELEN_TAVREL.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/npc/TALK_FORGE_MERCHANT.json Outdated Show resolved Hide resolved
@Maleclypse Maleclypse merged commit f1c803e into CleverRaven:master May 20, 2024
25 checks passed
@TheAthenaCabin0 TheAthenaCabin0 deleted the Update-Forge-Dialogue branch May 20, 2024 03:12
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Magiclysm] - Asking Seer to reveal an Orc Village leads to a Goblin Outpost with the mission "Visit the Orcs"
4 participants