Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include vehicle roofs for map::draw_from_above #73747

Merged
merged 1 commit into from
May 14, 2024
Merged

Include vehicle roofs for map::draw_from_above #73747

merged 1 commit into from
May 14, 2024

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented May 13, 2024 •
edited
Loading

Summary

None

Purpose of change

Fix #73029

Describe the solution

Flip a bool so curses renders vehicles roofs from z+1 correctly

Describe alternatives you've considered

Testing

Compile curses build, place vehicle near ramp, go on ramp - the debugmsg in the linked issue pops, doesn't pop after patch

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 13, 2024
@dseguin dseguin merged commit 5a2af37 into CleverRaven:master May 14, 2024
24 of 29 checks passed
@irwiss irwiss deleted the fix-73029 branch May 15, 2024 00:10
@NetSysFire NetSysFire added the curses Things specific to the curses variant of the game label May 15, 2024
@irwiss irwiss mentioned this pull request May 16, 2024
Closed
@RenechCDDA RenechCDDA mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` curses Things specific to the curses variant of the game json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rendering vehicles while on z-level >1 causes errors
3 participants
@irwiss @dseguin @NetSysFire