Define _XOPEN_SOURCE_EXTENDED on mac localized curses builds for wchar #73697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e wide character support
github-actions
bot
added
Code: Build
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
The macOS release build is broken as can be seen in https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/9046935560/job/24858676569#step:27:370
This happened in #73414 and again we didn't catch it because we don't have a macOS/curses build in the test suite.
Describe the solution
I stumbled across this incantation that might soothe the foul beast.
Describe alternatives you've considered
Tried to unpack wchar into utf8 strings in #73694 but I can't get that to work.
Testing
Can't test locally, it's up to the release osx curses build.