Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation: Update TropiCata #73663

Merged
merged 7 commits into from
Jun 7, 2024
Merged

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented May 11, 2024

Summary

None

Purpose of change

TropiCata has been rotting for a long while. Which is a shame because the idea behind it is cool. Recently due to some of my other PRs I looked at its code and... it's barely held together. So here I am, trying to make it a mod people play more than once in 6 months.

Describe the solution

  • Move the coordinates for sunrise to Central Brazil, also update the mod description to reflect that - literally all of the content here is based off South America. There's no point lying that it's some non-determined tropical region
  • Edit the regional groundcover so it's not riddled with underbrush every two steps
  • Remove the nonexistant mutant cactus ID from the regional settings so the game doesn't throw errors when generating a world
  • Update the regional blacklist to include mutant moose, some non-native birds and amphibians, most vanilla fish (with the exception of the goldfish, european carp, rainbow trout, and american eel, which have small but technically present populations in Brazil)
  • Cut out the wolves from the blacklist since they only spawn in zoos anyway
  • Remove duplicate goldfish definition since I added one in vanilla ages ago
  • Give the mod's monster factions some bases to work with so they function more dynamically in the world

TODO:

  • Figure out why the hell there's no forests anywhere - postponed until after region_settings -> region_overlay for mods #73602
  • Annoy @Procyonae to know if there's a more sustainable way to list which overmap extras can spawn and which ones can't. Defining it manually isn't gonna go far if vanilla gets new ones...

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. labels May 11, 2024
@Karol1223
Copy link
Contributor Author

@Xaritscin I'm gonna need to know if you're still active in the repo or not, because you've been MIA for like a year now

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 11, 2024
@Procyonae
Copy link
Contributor

The only reason I stuck the coords in Central America was bc there was some interest at the time of actually mainlining the region a realistic distance to the south (with start scenarios) when we get the ability to have multiple regions but idk how realistic that happening is

@Karol1223
Copy link
Contributor Author

The only reason I stuck the coords in Central America was bc there was some interest at the time of actually mainlining the region a realistic distance to the south (with start scenarios) when we get the ability to have multiple regions but idk how realistic that happening is

I am still against sacrificing 50% of the mod content to move the setting elsewhere, personally. Let it stay a mod. There's no reason for it to be vanilla unless we want to simulate all of the US, Mexico, and all the way down to Nicaragua.

@Procyonae
Copy link
Contributor

I am still against sacrificing 50% of the mod content to move the setting elsewhere, personally. Let it stay a mod. There's no reason for it to be vanilla unless we want to simulate all of the US, Mexico, and all the way down to Nicaragua.

Well that would be the hypothetical idea ye c;
If the mod has alot of Brazil specific wildlife etc though that's cool, nothing made it particularly obvious if it was intended to be anywhere specific

@Karol1223
Copy link
Contributor Author

If the mod has alot of Brazil specific wildlife etc though that's cool, nothing made it particularly obvious if it was intended to be anywhere specific

It also has some wildlife from outside Brazil, admittedly (one species of crab), but it was the only region I could find that had most of the current mod content fit it.

Anywho, the question about blacklisting/whitelisting overmap extras stands.

@Procyonae
Copy link
Contributor

Anywho, the question about blacklisting/whitelisting overmap extras stands.

What differences do you want there to be between vanilla and TropiCata extras?

@Karol1223
Copy link
Contributor Author

Anywho, the question about blacklisting/whitelisting overmap extras stands.

What differences do you want there to be between vanilla and TropiCata extras?

The point is - I don't think there need to be any? There might be some extras that wouldn't make sense in TropiCata, but most would. But if I'm reading the files correctly, currently in the regional settings there's a manually curated list of which map extras can spawn with the mod?

@Procyonae
Copy link
Contributor

Procyonae commented May 11, 2024

I'm using #73602 as a good excuse to go through and make most of the remaining region settings overlays instead so they don't need to maintain their own lists of city buildings and extras etc and I'll hit TropiCata in that bc it's affected by the bug

@Karol1223
Copy link
Contributor Author

I'm using #73602 as a good excuse to go through and make most of the remaining region settings overlays instead so they don't need to maintain their own lists of city buildings and extras etc

Gotcha. I'll ignore that part for now then and let you take care of that in this case.

@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map labels May 11, 2024
@Karol1223 Karol1223 force-pushed the TropiCata-updates branch from ce68a55 to 27cf902 Compare May 25, 2024 07:14
@github-actions github-actions bot added the Monsters Monsters both friendly and unfriendly. label Jun 4, 2024
@Karol1223 Karol1223 marked this pull request as ready for review June 4, 2024 18:11
@Karol1223
Copy link
Contributor Author

Since #73602 seems to be in limbo I'm gonna bite the bullet and get this merged in the current state. Doesn't fix all the issues I was hoping to tackle, but it at least makes the mod able to be loaded onto a world without an error screen so that's progress.

@Maleclypse Maleclypse merged commit 7b4efa6 into CleverRaven:master Jun 7, 2024
26 of 34 checks passed
@Karol1223 Karol1223 deleted the TropiCata-updates branch June 7, 2024 20:10
feinorgh pushed a commit to feinorgh/Cataclysm-DDA that referenced this pull request Jun 8, 2024
* region change

* fix the error + groundcover proportions

* lower dirt weight

* update the blacklist

* fish blacklisting

* blacklist amphibians

* factions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants