-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Forge of Wonder Globally Unique #73578
Make Forge of Wonder Globally Unique #73578
Conversation
iirc there are a few lines of dialogue from the various traders there that would have to be changed in addition to this flag - they indicate that there are many copies of the forge all over the world. Would that be fitting for a different pr? |
The diviner can give you directions to another forge, while saying that Valzaim intended having that many forges as part of a "plan" he have It will definetly need to be changed should the location becomes globally unique |
As an addition to this, since the forge will be unique I think it makes sense to give the npcs defined personalities. Right now they're rolled randomly, which is very apparent on the traders and can lead to some dramatically different pricing. |
It feels like adding distinct personalities and fleshing out the forge a bit more ties in with #73434. Maybe a forge overhaul is due à la the various faction overhauls we are seeing (exodii, hub, isherwoods, etc). Later this week I'll try to draft a pr on that matter, resolving some of the QoL features at least. |
Definitely support giving the various traders more definite traits and dialogue. While testing the above issue I discovered that forge dwarves can just wander into the lava. Added the higher level of danger avoid to fix that. |
Unless I'm missing something the talk topic TALK_FORGE_LORD_DIVINER_OTHER_FORGE where the mission is assigned also needs changing |
What do you think about that change I've just pushed? |
Summary
None
Purpose of change
The Forge was intended to be globally unique but the code to make it so didn't exist when it was first made. Now it does.
Describe the solution
Adds Globally unique flag.
Describe alternatives you've considered
Making it more rare than 1/16
Testing
Additional context