-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Skunks! #73537
Add Skunks! #73537
Conversation
If skunk spray gets in your eyes IRL it is completely blinding. It also impairs breathing and should probably induce nausea. It doesn't always get in your eyes, especially if you're a human, but it could conceivably be a big deal if this happened while you were fighting for your life. |
Unfortunately, because I made the effect hours long for the stinky spray part, I'm not sure how to make a separate blindness that won't last for hours. Slash I don't know how to make it target the eyes. Slash... I don't really know what I'm doing. This does cause nausea, the vomit chance is low (in testing I vomited like once in the three hour span) but had the recovery from nausea message about a dozen times, so unless I'm mistaken it will cause nausea or at least... printed the nausea recovery message for some reason idk. But again I don't know how to cause nausea without having it span hours, which I think would be a lot for a player, when for example the boomer nausea only lasts like a minute iirc. I agree there should probably be these things I'm just maybe not the one to properly execute it. |
Oh crap, sorry. Skimming your PR body, I didn't see that you had effects other than just the stat mods. Ignore me. For the blindness it'd probably be a matter of running an EOC when the effect is added that checks if it gets in the character's eyes. That's probably more complicated than the PR needs to be, it's just something I was coincidentally thinking about last night. |
Is it possible to trigger several EoCs by the same attack? That would allow you to have different durations on different effects (e.g. nausea for a limited time, but stinky for a whole lot longer, and ideally a short blinding effect if it hits the eyes). |
Re: multiple effects, you can make subspell that run after the first, that applies blindness, nausea etc etc with some chance, but i'd say to not bother if you find it difficult |
Co-authored-by: Anton Simakov <[email protected]>
Summary
Content "Added Skunks"
Purpose of change
Skunks did not exist in game but existed in New England, as was pointed out by NetSysFire in #70220 It wasn't clear if they were going to add them or if they were inviting others to contribute so I decided to give it a shot myself.
Describe the solution
Describe alternatives you've considered
I tried lots of things but this is what ultimately made sense for how to do it.
Testing
Lots of trial and error with the spell system, thanks to those who helped me through discord, notably GuardianDLL. I tested the skunk, the harvest, the spawns, the magic effect, the spell itself, everything seems to be working properly, with the exception of a little undesirable behavior from their aggression, which I outlined above.
Additional context