Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Jmathify and variable-ize power learning times #73529

Merged

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented May 5, 2024

Summary

Mods "[MoM] Jmathify and variable-ize power learning times"

Purpose of change

Someone suggested that intelligence and proficiencies should make learning new powers easier, and that's a completely reasonable request.

Implements #73519

Describe the solution

Replace the numeric values in the insight EoC and the variable power-learning EoCs with Jmath and variables. Variables are initiated on game start and as a one-time EoC that runs for existing games.

The values are the same as previously (tier 1 power EoCs run every 12 to 24 hours, insight is gained once every 12 to 168 hours, etc), but are now affected by various factors. Insight is gained 3% faster per point of intelligence above 10 (capped at 60% faster at 30 Intelligence) and 5% faster per point of Metaphysics above 5. The power-learning EoCs for each path run 3% faster per point of intelligence above 10 (capped at 60% faster as before) with a flat 20% bonus if you know the insight proficiency for that path.

Insight proficiencies have been reduced to requiring 32 h of practice.

Describe alternatives you've considered

Testing

EoCs still run, some observed times were lower than previous possible minima.

Loaded into a game made before the changes, EoCs still functioned.

Additional context

Man it sure is fun to test things in a mod based on unpredictable outcomes

@Standing-Storm Standing-Storm marked this pull request as draft May 5, 2024 19:06
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Crafting / Construction / Recipes Includes: Uncrafting / Disassembling EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter labels May 5, 2024
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 5, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 5, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review May 5, 2024 21:58
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 6, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 6, 2024
@Maleclypse Maleclypse merged commit 08a8580 into CleverRaven:master May 7, 2024
20 of 24 checks passed
@Standing-Storm Standing-Storm deleted the power-learning-variables branch May 7, 2024 14:08
akrieger added a commit that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants