Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maps only highlight newly revealed OMTs #73522

Merged

Conversation

RenechCDDA
Copy link
Member

Summary

Interface "Overmap only highlights newly revealed OMTs for maps"

Purpose of change

A much better implementation

Describe the solution

Check if we've seen the OMT before adding it to the list to highlight. If we have already seen it, we don't highlight it

Describe alternatives you've considered

Testing

image
image

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 5, 2024
@XygenSS
Copy link
Contributor

XygenSS commented May 5, 2024

Is it possible to write "The map reveals no new information" or something along those lines to the log?
Could be confusing if you activated a map and found no reveals.

@RenechCDDA
Copy link
Member Author

Is it possible to write "The map reveals no new information" or something along those lines to the log? Could be confusing if you activated a map and found no reveals.

Yeah sure why not

2024-05-05.06-49-20.mp4

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 5, 2024
@Maleclypse Maleclypse merged commit 0a00a5c into CleverRaven:master May 6, 2024
22 of 26 checks passed
@RenechCDDA RenechCDDA deleted the only_highlight_new_reveals branch May 6, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants