Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Xedra Evolved ] Give Liam opinions about the XE world and missions #73500

Merged
merged 2 commits into from
May 17, 2024

Conversation

Maleclypse
Copy link
Member

Summary

Mods "Give Liam opinions in XE"

Purpose of change

Gives Liam opinions about the XE world so that it feels more connected.

Describe the solution

Add dialogue snippets for chatting and missions. Realize I need to add a ton of missions in XE.

Describe alternatives you've considered

None

Testing

@I-am-Erk Do you mind giving this a look to see if I've appropriately grasped the speech patterns of Liam?

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Xedra Evolved Anything to do with Xedra Evolved labels May 4, 2024
Copy link
Contributor

github-actions bot commented May 4, 2024

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Is Lewis Carrol hiding behind a bush over there? Because if not, this sounds insane and insanely dangerous. But no one else has even given us a hint about a way off this world of the dead. Can we really pass this by?

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 4, 2024
@Fris0uman Fris0uman merged commit 2ed4b66 into CleverRaven:master May 17, 2024
19 of 24 checks passed
@Maleclypse Maleclypse deleted the Give-Liam-Dialogue-about-XE branch May 20, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants