Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dummies less dumb #73488

Merged
merged 5 commits into from
May 7, 2024

Conversation

TheMurderUnicorn
Copy link
Contributor

Summary

Bugfixes "Update Target Dummies to Require Diggable Terrain"

Purpose of change

Target Dummies state in their descriptions they needed to be embedded in the ground AND the construction required a digging tool, however they could be installed anywhere, even on non-diggable terrain.

Describe the solution

Using pre_flags, I made it so the starting terrain MUST be diggable to erect the training dummies. I also updated the furniture (only exists after player constructs it) to state it's embedded via its post in the ground. This also made it so when the construction menu is open, this text is displayed, letting the player know why they can't place it on a road/sidewalk/etc (not that any of us read descriptions)

Describe alternatives you've considered

Adding a second version of both dummies, allowing them to have a weighted base and thus be buildable anywhere. For now, I did not want to do this.

Testing

Verified they could be placed anywhere despite requiring digging. Made changes. Tested that they now only work on diggable terrain and that their descriptions were updated.

Additional context

Closes #73483

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 3, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 4, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 6, 2024
@Maleclypse Maleclypse merged commit bc28504 into CleverRaven:master May 7, 2024
20 of 24 checks passed
@TheMurderUnicorn TheMurderUnicorn deleted the MakeDummiesLessDumb branch May 7, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It's possible to install a training dummy without diggable groud
2 participants