Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore lost constant #73472

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

master didn't compile because of a missing constant, presumably due to mergers conflicting (e.g. one removing an unused constant while another used the previously unused constant).

Describe the solution

Add/Restore the constant.

Describe alternatives you've considered

Testing

Compilation only, since the error corrected is that 'master' doesn't compile.

Additional context

@github-actions github-actions bot added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 3, 2024
@Brambor Brambor added the <Bugfix> This is a fix for a bug (or closes open issue) label May 3, 2024
@Brambor
Copy link
Contributor

Brambor commented May 3, 2024

I assume General build matrix / GCC 9, Curses, LTO will break, since I broke it in #73400

@PatrikLundell
Copy link
Contributor Author

The reason I stumbled upon it was because I had to do a PR conflict resolution. Then the testing kicked off by that failed (I won't bother to check which one), and then I updated my local master copy and saw that it failed too. Hence this PR.

Brambor added a commit to Brambor/Cataclysm-DDA that referenced this pull request May 3, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 3, 2024
@dseguin dseguin merged commit 748383b into CleverRaven:master May 3, 2024
23 of 28 checks passed
@PatrikLundell PatrikLundell deleted the restore_open_air branch May 3, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants