enable barrel swabbing

[misterprimus]

Summary

Content "Adjust black powder fouling"

Purpose of change

Make black gunpowder usage and rusting mechanics more realistic.

Describe the solution

Added some CPP to enable ADJUSTMENTS to rust in addition to the existing SETTING of the dirt variable. Then added a fix and a fault. Also made rusting more dependent on dirt level.

Describe alternatives you've considered

Adjusting gun reliability based on dirt level.

Testing

Fired a black powder load and looked at how the rusting changed after the shot and after the mend procedure.

Additional context

I asked a reddit community specializing in this sort of stuff. See results below:

[I-am-Erk]

I'm not super familiar with how we're doing blackpowder fouling presently. Is this making it more, or less, annoying to manage?

[misterprimus]

I'm not super familiar with how we're doing blackpowder fouling presently. Is this making it more, or less, annoying to manage?

Swabbing gives you more time before the gun rusts with minimal tools and minimum time. There are some math changes as well but core mechanics remain the same. So I would say LESS annoying but not a panacea.

[misterprimus]

I'm not super familiar with how we're doing blackpowder fouling presently. Is this making it more, or less, annoying to manage?

Did you have any additional questions?

[Maleclypse]

Could you resolve conflicts? I wouldn't be sure how to fix that rebase.

[misterprimus]

Could you resolve conflicts? I wouldn't be sure how to fix that rebase.

Can you tell if this would work?

void fault_fix::load( const JsonObject &jo, std::string_view )
{
    mandatory( jo, was_loaded, "name", name );
    optional( jo, was_loaded, "success_msg", success_msg );
    optional( jo, was_loaded, "time", time );
    optional( jo, was_loaded, "set_variables", set_variables );
    optional( jo, was_loaded, "adjust_variables_multiply", adjust_variables_multiply );
    optional( jo, was_loaded, "skills", skills );
    optional( jo, was_loaded, "faults_removed", faults_removed );
    optional( jo, was_loaded, "faults_added", faults_added );
    optional( jo, was_loaded, "mod_damage", mod_damage );
    optional( jo, was_loaded, "mod_degradation", mod_degradation );
    optional( jo, was_loaded, "time_save_profs", time_save_profs );
    optional( jo, was_loaded, "time_save_flags", time_save_flags );

    if( jo.has_array( "requirements" ) ) {

[misterprimus]

Could you resolve conflicts? I wouldn't be sure how to fix that rebase.

I think I got it.