Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nether Monster Corpses - Yugg #73303

Merged
merged 12 commits into from
Jun 19, 2024
Merged

Nether Monster Corpses - Yugg #73303

merged 12 commits into from
Jun 19, 2024

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Apr 26, 2024

Summary

None

Purpose of change

Our Nether monsters have a plethora of different things that happen to their corpses on death. While this is on brand for chaos bullshit the nether is, we can do better than having them always disappear or just... give normal corpses, like this guy here.

Describe the solution

  • Slightly rebalance the stats for the yugg - remove dodge, increase size, give it GOODHEARING, RANGED_ATTACKER, PUSH_VEH
  • Add three new corpse items - rubber yugg corpse, oversized fleshy tube, jade yugg statue
  • Add new mutagenic flesh - obtained from the oversized fleshy tube, supposed to give random mutations when ingested
  • Add new deatheffect for Yugg that gives one of five results in the form of corpse undergoing material transmutation - steam (spawns steam fields), mutagenic flesh, rubber, glass (pile of black glass shards), and jade

Describe alternatives you've considered

Testing

I was able to get the different death effects to fire, so I consider it working. If there's any issues I haven't managed to catch them in testing

Additional context

The reason Yugg goes first is that it was the one most edible out of the bunch, and it really rubbed me the wrong way

@github-actions github-actions bot added the [JSON] Changes (can be) made in JSON label Apr 26, 2024
@GuardianDll
Copy link
Member

> glass (pile of glass shards)
i surely hope glass shards are accelerated toward any living and unliving creatures around?

@Karol1223
Copy link
Contributor Author

glass (pile of glass shards) i surely hope glass shards are accelerated toward any living and unliving creatures around?

So did you ever figure how to do that for your bombardier boomers so I can steal it from you, or are you trying to fool me into figuring out how to do this so you can steal it for the boomers? 🤔

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 26, 2024
@GuardianDll
Copy link
Member

sadly there is no proper way to use shrapnel from spell/EoC side, unless you want to make a spell, that just explode around

@Standing-Storm
Copy link
Contributor

and take away HAS_MIND which appears to be a flag cargo culted across most nether creatures

I added that, it's used in MoM and XE. It's for monsters with consciousness and that are capable of thought (I thought it was more interesting to imply that Yuggs were sapient). If Yuggs are just animals, they shouldn't have it.

@Karol1223
Copy link
Contributor Author

and take away HAS_MIND which appears to be a flag cargo culted across most nether creatures

I added that, it's used in MoM and XE. It's for monsters with consciousness and that are capable of thought (I thought it was more interesting to imply that Yuggs were sapient). If Yuggs are just animals, they shouldn't have it.

To be fair, when I read what the flag implies I assumed it was something used in MoM but I didn't check GitBlame. I laughed around a little on the devcord about this meaning Yuggs just find it funny to mutate survivors into weird shit, didn't realize it was intentional. The flag doesn't change anything for me so I'll give it back to them

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 26, 2024
@github-actions github-actions bot added the Monsters Monsters both friendly and unfriendly. label May 14, 2024
@Karol1223
Copy link
Contributor Author

@GuardianDll I'm gonna need your review as to why the hell do the messages I wrote for the EoC not get printed

@GuardianDll
Copy link
Member

Because you use u_message, but in case of EoC, run by death effect, u is monster, and npc is avatar. Swap u_message to npc_message

@worm-girl
Copy link
Contributor

If you are looking for more nether critter corpse ideas, either here or in a future PR, having some of them petrify and rapidly burn into a pile of quicklime would be both really cool and situationally handy. There have been a few occasions where I needed a ton of the stuff and it can be kind of annoying to track down.

@TheSaddestGoomba
Copy link
Contributor

If you are looking for more nether critter corpse ideas, either here or in a future PR, having some of them petrify and rapidly burn into a pile of quicklime would be both really cool and situationally handy. There have been a few occasions where I needed a ton of the stuff and it can be kind of annoying to track down.

The Nuckelavee may be a good choice for that, though with washing soda instead of quicklime. There are elements of period folklore that claim burning seaweed for soda ash would enrage them. Makes some sense they would collapse into a steaming pile of what they hate.

@Karol1223
Copy link
Contributor Author

Karol1223 commented May 16, 2024

If you are looking for more nether critter corpse ideas, either here or in a future PR, having some of them petrify and rapidly burn into a pile of quicklime would be both really cool and situationally handy. There have been a few occasions where I needed a ton of the stuff and it can be kind of annoying to track down.

I do need ideas, but I am still really trying to feel out just how helpful I want those corpses to be. Keep in mind that nether monsters are infinitely renewable. I do not want to make minecraft-esque material farms. I already am making those for glass and rubber with this, and I don't like that.

The Nuckelavee may be a good choice for that

Full disclosure, I likely will not touch the Nuckalavee at all with this project. It's currently my least liked Nether critter since it is 100% just a direct rip from folklore. I feel a similar way about the albino penguin (with the difference being it is a direct rip from Lovecraft, as opposed to being named after Lovecraft critters with most of our other similar fellas) but it gets more leeway because penguins are awesome.

@GuardianDll
Copy link
Member

> I already am making those for glass and rubber with this
Replace glass with black glass, iirc it's completely useless

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 17, 2024
@Karol1223 Karol1223 marked this pull request as ready for review June 17, 2024 17:09
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 17, 2024
@Maleclypse
Copy link
Member

I've resolved the conflict and replaced the special attack. Everything else I left as you have adjusted.

@Maleclypse Maleclypse merged commit e4840ea into CleverRaven:master Jun 19, 2024
22 of 24 checks passed
@Karol1223 Karol1223 deleted the yugg branch June 21, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants