Revert "automatically open to favorites tab"

[Vsevolod-Shustov]

Summary

Interface "Revert 'Spellcasting menu - automatically open to favorites tab if player has favorited spells'"

Purpose of change

Make hotkeys for non-favorite spells work without extra left arrow press to go to "All" tab

Describe the solution

Make "All" tab default like it was since spellcasting menu was introduced

Describe alternatives you've considered

Make hotkeys for spells not in the current tab work *

• I didn't actually consider coding it

Testing

None whatsoever

Additional context

#72643
#72849

[Brambor]

@Blueflowerss might want to comment?

[Vsevolod-Shustov]

I'll bump this as @Blueflowerss doesn't seem interested in commenting.

[I-am-Erk]

What's the reason for this? Neither this nor your issue explain the problem, so I have no way to tell if we should be merging this or not.

[Vsevolod-Shustov]

What's the reason for this? Neither this nor your issue explain the problem, so I have no way to tell if we should be merging this or not.

Spell hotkeys only work when the spell is in the currently displayed list (all, favorites, magic/psionic schools). Before the PR I want reverted it wasn't an issue as by default spellcasting menu displayed "all" list, thus to cast a spell you assigned to a hotkey, you pressed spellcasting hotkey, then spell hotkey (two buttons). After that pr (now) spellcasting hotkey opens "favorites" list, and to cast arbitrary spell you press spellcasting hotkey, left arrow (to switch to "all" list), spell hotkey (three buttons).

[Fris0uman]

We should probably fix the hotkey behaviour instead and make it work on any tab, no?

[Vsevolod-Shustov]

Can UX regression and broken muscle memory be fixed before that?

[Brambor]

You could also add an option for what default tab to open. But CDDA devs don't like too many settings.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[Brambor]

I am closing this since the purpose was solved by:

• Allow using hotkeys to select spells in other categories #74281