Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pigeon reproduction + Foundations for future bird audit #73057

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Apr 16, 2024

Summary

None

Purpose of change

Pigeons could not breed and that made me sad

Describe the solution

NEW Bird Abstract

  • For the most part identical to old pigeon definition, new stuff includes PATH_AVOID_FIRE and PET_WONT_FOLLOW flags, reproduction flags for spring and summer so they don't breed all year round, lowered proportional volume (and a fancy JSON note to boot!) and 25% higher speed. Also removed SMELLS
  • Currently only used by pigeons. I intend to make more extensive use of this when I get to auditing wildlife more thoroughly

Chick Abstract

  • Volume lowered to 80ml because the old volume was ridiculous
  • Added CANPLAY for the abstract - for chicks that aren't tameable this changes nothing, for chicks that were this saves on a few JSON lines
  • Removed that one weird flat cut damage they'd do in fights (??)
  • Added fear triggers

Pigeon

  • Slighly lowered weight, significantly lowered volume
  • Renamed to "feral pigeon" in case we wanna add some other pigeons/doves in the future. I know I do
  • Added reproduction, chicks and eggs for it

Describe alternatives you've considered

Testing

Additional context

Density taken from https://svpow.com/2013/06/01/how-dense-are-birds-some-new-old-data-also-hummingbirds-and-ketchup/, since our birds are alive so I had to take air sacks into consideration

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 16, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 16, 2024
@Maleclypse Maleclypse merged commit 0853a71 into CleverRaven:master Apr 17, 2024
24 checks passed
@Karol1223 Karol1223 deleted the pigon branch April 17, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants