Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DinoMod] Add physiology proficiency training to all monsters #73042

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

Karol1223
Copy link
Contributor

Summary

None

Purpose of change

99% of vanilla monsters nowadays train physiology. It was weird DinoMod monsters didn't, but I assumed it was just because when physiology was made widespread it was done only for vanilla.

Describe the solution

Add physiology to all DinoMod creatures that had defined proficiencies they train

Describe alternatives you've considered

Doing some copy-from cleanup to get the families added via extend. Don't really feel like doing this for 100+ monsters

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) labels Apr 15, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @LyleSY

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 15, 2024
Copy link
Contributor

@LyleSY LyleSY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, thanks!

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 15, 2024
@Maleclypse Maleclypse merged commit aeba95b into CleverRaven:master Apr 15, 2024
20 of 26 checks passed
@Karol1223 Karol1223 deleted the dinomod-physiology branch April 16, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods Issues related to mods or modding
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants