Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Technomancer pain ignore spell #73025

Merged
merged 6 commits into from
Apr 21, 2024

Conversation

rty275
Copy link
Contributor

@rty275 rty275 commented Apr 14, 2024

Summary

Mods "Technomancer pain ignoring spell"

Purpose of change

Pain's effects on stats got jsonized, time to make a spell about it.

Describe the solution

This is a very niche spell, something that is only really good for breaking out of a death spiral, but very useful for that purpose, as it'll reduce your pain penalties to nearly zero at max level (can't go to zero, stat reductions have to be -1 at least from my understanding) but it only lasts a very brief amount of time. That said, if you're in any amount of severe pain, you'll recoup the move cost of casting it by not having your speed reduced for the duration of the spell, so long as its sufficiently leveled.

Describe alternatives you've considered

Not making it?

Testing

Spell learned correctly, cast correctly, effect scaled with level correctly and was removed correctly at time limit, and scroll spawned in itemgroup correctly. Can't think of anything else?

Additional context

I'm a little curious about why pain stat reduction is always at least a 1, but it still fits the spell to make it imperfect even at max level.

@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells labels Apr 14, 2024
@github-actions github-actions bot requested a review from KorGgenT April 14, 2024 18:11
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 14, 2024
@Maleclypse
Copy link
Member

Can it also cost bionic power? That way it mimics you having some machine inside you at least a power storage cbm.

@rty275
Copy link
Contributor Author

rty275 commented Apr 16, 2024

It can, sure. I worry that just makes it a strictly worse Sensory Dulling CBM in that case though. Also I'm realizing I don't understand the lore on any spells costing bionic power at all, if bionics are coming exclusively from the exodii now.

@rty275 rty275 marked this pull request as draft April 17, 2024 15:02
@rty275
Copy link
Contributor Author

rty275 commented Apr 17, 2024

Converting to draft so it doesn't get merged while we're talking about it.

@Maleclypse
Copy link
Member

It can, sure. I worry that just makes it a strictly worse Sensory Dulling CBM in that case though. Also I'm realizing I don't understand the lore on any spells costing bionic power at all, if bionics are coming exclusively from the exodii now.

Bionics don’t come from the Exodii exclusively in Magiclysm lore. Technomancers invented them. Just no one has run with that lore tidbit and done anything to add them back. If you don’t have a sensory dulling cbm you don’t have any other option than this now would you?

@rty275
Copy link
Contributor Author

rty275 commented Apr 17, 2024

Huh, I didn't realize Technomancers made them, that's a cool bit of lore. Maybe I should make an attempt at spreading them back around, though that sounds like a big undertaking. In any case, that's an idea for a different PR, I'll change this to bionic power then. Probably lower the cost too, because of the short duration

@rty275 rty275 marked this pull request as ready for review April 17, 2024 19:20
@rty275
Copy link
Contributor Author

rty275 commented Apr 20, 2024

Right, I think that test failure seems unrelated? Not my area of expertise though, so if there's something I need to fix then let me know.

EDIT: Well there we go, all green, thanks to whoever kicked the tests!

@Maleclypse Maleclypse merged commit 8281fcf into CleverRaven:master Apr 21, 2024
24 checks passed
@rty275 rty275 deleted the technomancer-pain-ignore branch April 22, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants