Unhardcode dead vegetation extras #73022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Realised I had 2 half a year old local branches unhardcoding extras that I forgot to finish '^^
Hardcode bad
Describe the solution
Unhardcode
mx_dead_vegetationandmx_point_dead_vegetationDoesn't delete
dead_vegetation_parser()bc it's annoyingly used bymx_portal_inmx_dead_vegetationnow only affects some of the map rather than the perfect square it affected beforeDescribe alternatives you've considered
Ideally I'd get around to making
ter_furn_transforms to transforming between types and to include items but I imagine that's quite a bit of work so for now this just randomly places items in the affected area.Testing
Additional context
Example of
mx_dead_vegetation:Example of
mx_point_dead_vegetation: