Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meat Lab Ghoul Nests #73007

Closed

Conversation

John-Candlebury
Copy link
Member

Summary

Content "Create unique content for the meat lab."

Purpose of change

Quite the title.

Add some unique chunks that directly relate to the monsters in: #72969. Meant to spawn both the creatures and items/mechanics directly related to them.

More incoming as the linked PR develops.

Describe the solution

Uses the same chunk-parametric pallete system that powers the normal and meat microlab variants.

Describe alternatives you've considered

Testing

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 14, 2024
@KHeket
Copy link
Contributor

KHeket commented Apr 14, 2024

Can you also remove or highly reduce number of breathers mentioned in #71349 because of them the meat labs became a most fps death places?

@PatrikLundell
Copy link
Contributor

Minor linguistic clarification: A pallet is something used for moving goods around, while a palette is what painters use when painting. Probably not much risk for confusion, as pallets aren't used in the game, I think. I've seen several cases of the wrong word being used, hence this comment.

@John-Candlebury
Copy link
Member Author

Can you also remove or highly reduce number of breathers mentioned in #71349 because of them the meat labs became a most fps death places?

Gave the issue a read and it seems the bug is related to monster vision, they are processing vision even when their definitions state they should be blind. Not able to fix this, and I rather not simply hide the underlying bug by making the breathers not spawn. Sorry.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label May 14, 2024
@github-actions github-actions bot closed this Jun 13, 2024
@Maleclypse Maleclypse reopened this Jun 16, 2024
@Maleclypse
Copy link
Member

Hey John, if you don't mind I'm going to look at getting this complete.

@github-actions github-actions bot removed the stale Closed for lack of activity, but still valid. label Jun 16, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jul 17, 2024
@Night-Pryanik
Copy link
Contributor

Closing as stale. If you wish to continue working on this, ping me to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display stale Closed for lack of activity, but still valid.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants