Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some facial hair styles prevent gas masks activation #73006

Closed

Conversation

BalthazarArgall
Copy link
Contributor

Summary

Features "Some facial hair styles now prevent you from using gasmasks"

Purpose of change

Santa can't wear a gas mask.

Describe the solution

Big beard = no gas mask, mustache ok though.

Describe alternatives you've considered

Invert the if statement and check for a GASMASK_COMPATIBLE flag, I dunno, maybe it's more intuitive?

Testing

Tried activating a dust mask with a beard, couldn't.

Additional context

Let's have a debate about what facial hair should be gas mask compatible.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 13, 2024
@BalthazarArgall
Copy link
Contributor Author

@DoctorBoomstick 🎁

Do tell me what you think about what facial hair I chose to make incompatible.

@DSeyka
Copy link
Contributor

DSeyka commented Apr 14, 2024

One would expect facial hair (and other appearance traits) to be a purely aesthetic choice without any gameplay ramifications.

@AnotherSeawhite
Copy link
Contributor

I think this might need a feature that allows us to cut the facial on the spot with scissors or a hair trimmer to lessen the frustration. Not to mention this would cause inconsistencies like people with afro hair being able to wear a full-sized helmet.
On the other hand, DSeyka is right. Many people wouldn't like it.

@DoctorBoomstick
Copy link
Contributor

Off the top of my head, before delving into the files, we’d need some way to shave or trim facial hair. I know we have shaving kits, but come to think of it, I don’t know if they affect beard length at all. Second, we should probably note this down in some player-facing way so people with no knowledge of gas masks don’t amble off into a toxic area with a full Santa beard and then have the unpleasant surprise that they cannot, actually, use their mask. It’d be nice if this were viewable in a reliable way around the world. For example, I wrote a CBRN training video description for the E logs, but we should have this noted in the gas mask’s description in lieu of that.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 14, 2024
@esotericist
Copy link
Contributor

while i acknowledge that there is a very reasonable logic here, it's important to note that we've been making it a point to keep certain things that exist for player identity -- including selected gender, and the various cosmetic traits -- as purely cosmetic, with no in-game effect.

this pr conflicts with that, and so unfortunately neither this nor anything similar to it should be merged.

@BalthazarArgall BalthazarArgall deleted the HairVsGasmask branch April 15, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants