-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused/already jsonized hardcoded monster attacks #73004
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
[C++]
Changes (can be) made in C++. Previously named `Code`
Monsters
Monsters both friendly and unfriendly.
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Apr 13, 2024
github-actions
bot
added
Mods
Issues related to mods or modding
Mods: Aftershock
Anything to do with the Aftershock mod
labels
Apr 13, 2024
github-actions
bot
added
the
Mods: Dinomod
Anything to do with the Dinoclysm mod (DinoMod)
label
Apr 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @LyleSY
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Apr 13, 2024
This is a solid PR Karol! I know you do lots of work here but this one made me realize I hadn't thanked you recently. Thank you for all you do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: Aftershock
Anything to do with the Aftershock mod
Mods: Dinomod
Anything to do with the Dinoclysm mod (DinoMod)
Mods
Issues related to mods or modding
Monsters
Monsters both friendly and unfriendly.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
We had some old monster attacks that have already been jsonized but stuck around
Describe the solution
Delete some old monster attacks that have already been jsonized but stayed around in C++ for... reasons?
Replace the hardcoded versions of them with jsonified versions whenever in use
Affected the following
Describe alternatives you've considered
Testing
Additional context