Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused/already jsonized hardcoded monster attacks #73004

Merged
merged 18 commits into from
Apr 14, 2024

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Apr 13, 2024

Summary

None

Purpose of change

We had some old monster attacks that have already been jsonized but stuck around

Describe the solution

Delete some old monster attacks that have already been jsonized but stayed around in C++ for... reasons?
Replace the hardcoded versions of them with jsonified versions whenever in use
Affected the following

  • stretch_bite
  • tentacle
  • impale
  • longswipe

Describe alternatives you've considered

  • smash - not possible to remove, the hardcoded version is still used as a part of another hardcoded special
  • bio op takedown and impale - used as part of bio op biojutsu
  • stretch attack - used in one melee test that I don't know how to edit them out of

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 13, 2024
@github-actions github-actions bot added Mods Issues related to mods or modding Mods: Aftershock Anything to do with the Aftershock mod labels Apr 13, 2024
@github-actions github-actions bot added the Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) label Apr 13, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @LyleSY

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 13, 2024
@Maleclypse
Copy link
Member

This is a solid PR Karol! I know you do lots of work here but this one made me realize I hadn't thanked you recently. Thank you for all you do!

@Maleclypse Maleclypse merged commit 4a328a6 into CleverRaven:master Apr 14, 2024
22 of 26 checks passed
@Karol1223 Karol1223 deleted the destroy-impale branch April 15, 2024 19:29
Maleclypse pushed a commit that referenced this pull request Apr 18, 2024
* docs

* Update monster_attacks.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants