Fixed segfault when an NPC completes a pickup after a player has alre…

[Levitator0]

abusive off-topic commentary removed

[mqrause]

Those suggested astyle changes strongly indicate you got some missing or extra braces.

Also please remove unnecessary code instead of just commenting it out. If you think a justification of the removal is necessary, put it in the PR text.

[Levitator0]

Those suggested astyle changes strongly indicate you got some missing or extra braces.

Also please remove unnecessary code instead of just commenting it out. If you think a justification of the removal is necessary, put it in the PR text.

There was an ubraced single-line else statement, so maybe that's the issue. I don't think I know how to read some of those prompts, so I didn't commit them. If the devs want to assume style changes are always valid, they're welcome to apply them.

[mqrause]

Please check the style guide for how we make sure everyone uses the same code style. Commits become very messy very fast if everyone uses their own favorite style.
As a rule of thumb, astyle is always right. And if code you didn't touch fails astyle checks, it's almost certainly an error in the code you did touch.

And as another rule of thumb, please don't mark suggestions as resolved when you're unsure about why they're there and what they try to achieve.

Edit: I left a comment on the third review, in case you didn't see that.

[Levitator0]

Please check the style guide for how we make sure everyone uses the same code style. Commits become very messy very fast if everyone uses their own favorite style. As a rule of thumb, astyle is always right. And if code you didn't touch fails astyle checks, it's almost certainly an error in the code you did touch.

And as another rule of thumb, please don't mark suggestions as resolved when you're unsure about why they're there and what they try to achieve.

Edit: I left a comment on the third review, in case you didn't see that.

I'm beyond confused as to how this issue resolution system interacts with the lint bot. I have totally lost the thread. It seems like the number of issues to resolve has only climbed. It doesn't upfront distinguish between an issue that was closed accepted/committed or closed as disregarded. And now I have a bunch of style issues, where when I attempt to commit them, GitHub complains that edits on deleted lines are not supported. Well, then why is it proposing the commit? I have no idea how to use this arrangement. I'm going to try to lint the code locally and then either update the PR, or reissue it, because this is driving me crazy.

[Levitator0]

Ok, I linted locally, and I have to conclude that astyle flips out and becomes totally confused if you leave the braces off of a single-line else statement. In any case, the code passes the automated check on GitHub now, so I'm going to mark all of the linting conversations as resolved because linting passes both locally and online. Sorry for the mess, as this setup confused the daylights out of me.

[NetSysFire]

1. You can batch apply suggestions.
2. You still need to fix your PR summary.

Also dear mergers, please squash this one.

[Levitator0]

1. You can batch apply suggestions.

   2. You still need to fix your PR summary.

Also dear mergers, please squash this one.

What's wrong with my summary?

[NetSysFire]

The summary section must contain exactly one line, in the format of Category "Description here". See test failure of the PR validator test. The category to use here is Bugfixes. Move your closing keyword into the Purpose of change section.

If you stayed just 10 minutes longer on IRC I would have helped you there.

[I-am-Erk]

To my limited skill the code looks good, just some comments on comments.

[Zireael07]

Why close?

[ZhilkinSerg]

Why close?

I do not think they want to contribute.