Cleanup unused stuff in mapgen_functions.cpp #72954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
This reverts commit 759603f.
github-actions
bot
added
json-styled
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Unused code not cool
Describe the solution
Removes rift and hellmouth functions that stopped spawning in #32464.
Removes mapgen_null which as far as I can see can't possibly spawn bc the null id for oter_t is "" not "null", and purposefully doesn't have a map so it triggers an error.
Removes header definitions of mapgen_cave and mapgen_cave_rat that don't exist anymore.
Unhardcodes empty_rock and open_air.
Describe alternatives you've considered
Testing
Game compiles, no relevant errors tping around
Additional context