Fix config/font.json generation to append correct paths for Android

[oosyrag]

Summary

Bugfixes "Android: Added correct path for default Terminus font"

Purpose of change

Fixes #72922

This is a really old Android bug, as was noted in https://www.reddit.com/r/cataclysmdda/comments/ppwq9f/cataclysm_dda_on_android_an_indepth_tweaking_guide/, nearly 3 years ago. This will let Android users see/use the bundled Terminus font by default, without having to jump through hoops replacing or editing files manually. Showing Terminus as the default makes a world of difference in how nice the game appears compared to unifont (see screenshots in attached issue and reddit post).

Describe the solution

Copied the function that adds the correct path to unifont (which works properly), adjusted for Terminus.

Describe alternatives you've considered

This solution would force terminus to be added even if it was removed (to back of the list, but in front of unifont). Perhaps a more elegant solution would be to craft a function that just validates and fixes an invalid path for any entry in the list only if the entry exists to begin with, while leaving the ensure_unifont_loaded function be the one that specifically adds unifont to the back if it doesn't exist.

(I don't know how to do this off the top of my head but pretty confident I could figure it out. Eventually.)

Testing

None. I have no idea how to compile for Android. Help please and thanks.

Edit: compiled and tested on Windows, nothing looks out of the ordinary, the functions don't appear to change anything, as expected.
fonds.json result:

{
  "typeface": [ "data/font/Terminus.ttf", "data/font/unifont.ttf" ],
  "map_typeface": [ "data/font/Terminus.ttf", "data/font/unifont.ttf" ],
  "overmap_typeface": [ "data/font/Terminus.ttf", "data/font/unifont.ttf" ]
}

Additional context

Review appreciated, I have no c++ background and also don't know if this is the proper way to solve the issue. And as mentioned above not sure how to compile to test...

[oosyrag]

Draft, tested on Android and didn't work.
Or I compiled wrong...

[oosyrag]

This approach did not work. While the outputted fonts.json ended up as expected, Terminus still doesn't get loaded unless the entries with incorrect paths ahead of it are deleted or the correct path is moved to the front of the list.

{
  "typeface": [ "data/font/Terminus.ttf", "data/font/unifont.ttf", "/storage/emulated/0/Android/data/com.cleverraven.cataclysmdda.experimental/files/data/font/Terminus.ttf", "/storage/emulated/0/Android/data/com.cleverraven.cataclysmdda.experimental/files/data/font/unifont.ttf" ],
  "map_typeface": [ "data/font/Terminus.ttf", "data/font/unifont.ttf", "/storage/emulated/0/Android/data/com.cleverraven.cataclysmdda.experimental/files/data/font/Terminus.ttf", "/storage/emulated/0/Android/data/com.cleverraven.cataclysmdda.experimental/files/data/font/unifont.ttf" ],
  "overmap_typeface": [ "data/font/Terminus.ttf", "data/font/unifont.ttf", "/storage/emulated/0/Android/data/com.cleverraven.cataclysmdda.experimental/files/data/font/Terminus.ttf", "/storage/emulated/0/Android/data/com.cleverraven.cataclysmdda.experimental/files/data/font/unifont.ttf" ]
}

The better approach is probably to not "hardcode" the paths in json, and write them to the fonts.json file by prepending the PATH_INFO::fontdir() instead, and having only the font name in fontdata.json. But I'm pretty sure it was changed FROM that a few years ago... time to find out why.

[ZhilkinSerg]

IMO font selection should be reworked to allow specifying font names explicitly (e.g. in Android launch menu and optionally duplicated in game settings).