Fix ASan error, suppress more checks #72900
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
#72879 failed to solve the whole problem and included a sloppy ASan error.
Hopefully fix that.
Describe the solution
Same basic logic as the previous PR, with an added caveat that basegame traits still trip the error.
Describe alternatives you've considered
Testing
Same test trait , trips an onload error when from the same source as its out-of-category prereq, doesn't complain for a basegame prereq mismatch.
I'll need to check if it actually solves the bloody ravenfolk stuff on the feathered arms, hence the draft.
Additional context
Not flagging the PR as ready to merge before reading all the unit tests might be a good idea. We'll see if I learn.