Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ASan error, suppress more checks #72900

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

Venera3
Copy link
Member

@Venera3 Venera3 commented Apr 8, 2024

Summary

None

Purpose of change

#72879 failed to solve the whole problem and included a sloppy ASan error.
Hopefully fix that.

Describe the solution

Same basic logic as the previous PR, with an added caveat that basegame traits still trip the error.

Describe alternatives you've considered

Testing

Same test trait , trips an onload error when from the same source as its out-of-category prereq, doesn't complain for a basegame prereq mismatch.
I'll need to check if it actually solves the bloody ravenfolk stuff on the feathered arms, hence the draft.

Additional context

Not flagging the PR as ready to merge before reading all the unit tests might be a good idea. We'll see if I learn.

@github-actions github-actions bot added Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 8, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 8, 2024
@Venera3
Copy link
Member Author

Venera3 commented Apr 8, 2024

No load errors in the AFS/Magiclysm/MoM/Limbs catastrophe save, should be good.

@Venera3 Venera3 marked this pull request as ready for review April 8, 2024 09:37
src/mutation_data.cpp Outdated Show resolved Hide resolved
@kevingranade kevingranade merged commit ac2d4a7 into CleverRaven:master Apr 9, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants