Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow EOCs to search items by caloric content #72886

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Allow EOCs to search items by caloric content #72886

merged 2 commits into from
Apr 9, 2024

Conversation

Karol1223
Copy link
Contributor

Summary

None

Purpose of change

Well this wasn't possible. Initially I thought this could have a vanilla use case in making sure the beggars at the refugee center only accept food with 0< kcal, but I believe it's not actually compatible with how their dialogue is set up

Describe the solution

Describe alternatives you've considered

Testing

Tried out a testing EOC that'd bring up items above 100 kcal - did indeed bring those items up

Additional context

This was all done by @RenechCDDA, I just compiled it, tested it and added the bit to the docs

RenechCDDA
RenechCDDA approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@RenechCDDA RenechCDDA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did work when I tried it.

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 7, 2024
@ashGlaw
Copy link
Contributor

ashGlaw commented Apr 7, 2024

Good teamwork!

Karol1223 and others added 2 commits April 9, 2024 11:07
@Karol1223 @RenechCDDA
I am merely a conduit
a1237ce 
Renech did literally all of this

Co-Authored-By: RenechCDDA <[email protected]>
@Karol1223
documentation
6b40d56
@Karol1223 Karol1223 force-pushed the calories-calories-mmm branch from 7927f9a to 6b40d56 Compare April 9, 2024 09:08
@dseguin dseguin merged commit dc205a2 into CleverRaven:master Apr 9, 2024
25 of 26 checks passed
@Karol1223 Karol1223 deleted the calories-calories-mmm branch April 10, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RenechCDDA RenechCDDA RenechCDDA approved these changes

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Karol1223 @ashGlaw @RenechCDDA @dseguin