[MoM] Oubliette works on NPCs now #72876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[MoM] Oubliette works on NPCs now"
Purpose of change
When working on #72784, I learned how to account for banishment on NPCs using EoCs, so it's time to let Oubliette affect NPCs too.
Describe the solution
Change Oubliette to an EoC that saves the damage-calculations as a variable on the target and compares it to their HP. If greater than their HP, they disappear to another dimension.
Describe alternatives you've considered
Testing
Banished some NPCs and monsters. Usually it worked, sometimes it didn't (thanks to random damage). At low levels, the reverse was true.
Additional context
if teleporting to alternate worlds or Nether subdimensions is ever implemented, be prepared for feral Teleporters to use Oubliette on you.