Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Oubliette works on NPCs now #72876

Merged
merged 11 commits into from
Apr 8, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Apr 7, 2024

Summary

Mods "[MoM] Oubliette works on NPCs now"

Purpose of change

When working on #72784, I learned how to account for banishment on NPCs using EoCs, so it's time to let Oubliette affect NPCs too.

Describe the solution

Change Oubliette to an EoC that saves the damage-calculations as a variable on the target and compares it to their HP. If greater than their HP, they disappear to another dimension.

Describe alternatives you've considered

Testing

Banished some NPCs and monsters. Usually it worked, sometimes it didn't (thanks to random damage). At low levels, the reverse was true.

Additional context

if teleporting to alternate worlds or Nether subdimensions is ever implemented, be prepared for feral Teleporters to use Oubliette on you.

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding [Markdown] Markdown issues and PRs EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 7, 2024
@Maleclypse Maleclypse merged commit ea8f34c into CleverRaven:master Apr 8, 2024
21 of 25 checks passed
@Standing-Storm Standing-Storm deleted the oubliette-npcs branch April 8, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants