Add dodge chance enchantment #72855
Merged
Add dodge chance enchantment #72855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
<Bugfix>
|
It says
Does it increase effective Dodge skill? |
github-actions
bot
added
the
BasicBuildPassed
|
It affects the dodge same as dodge skill do, but i thought it was not appropriate to use the skill itself (and also i recall using enchantment skill screws the skill training, stopping any progress whatsoever) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
#72842 made me found that
BONUS_DODGEis not a replacement for DODGE_CHANCEfix #72842
Describe the solution
Implement enchantment DODGE_CHANCE
Replace all values changed in c44e4e1 to use dodge chance instead
Testing
Additional context
Doesn't show changes in @ menu, because our enchantments are surprisingly harsh against UI and don't like to be shown
Unless someone teach me how to fix it (not only for this enchantment, but overall), i'll consider it to be enough