Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed out of bounds transparency cache access #72850

Merged

Conversation

l29ah
Copy link
Contributor

@l29ah l29ah commented Apr 5, 2024

Summary

Bugfixes "Fixed out of bounds transparency cache access"

Purpose of change

Fix crashes.

Describe the solution

The problem is caused by points_in_radius() producing negative coordinates.

Used #72747 (comment)

Fixes #70229
Fixes #72652

Describe alternatives you've considered

Testing

Additional context

The problem is caused by points_in_radius() producing negative coordinates.

Used CleverRaven#72747 (comment)

Fixes CleverRaven#70229
Fixes CleverRaven#72652
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 5, 2024
@dseguin dseguin merged commit 22e5420 into CleverRaven:master Apr 9, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failure in map::light_transparency SIGSEGV in field_processor_fd_electricity
2 participants