Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and cleanup few itemgroups #72821

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Some stuff is spawned as 30 containers with 1 thing inside, instead of 1 container with 30 things inside
image

Describe the solution

Added "container-item": "null" to overwrite their default container. I should have to remove their default container completely tho
Made sugar_packed for 1 pound of sugar in paper bag, replaced all places where sugar spawns without the itemgroup
Tweaked some sugar itemgroups to simplify stuff
Do the same with tea itemgroups

Testing

image

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display Items: Food / Vitamins Comestibles and drinks Spawn Creatures, items, vehicles, locations appearing on map Mods: No Hope Relating to the mod No Hope labels Apr 3, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Night-Pryanik

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Apr 3, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Apr 4, 2024
@I-am-Erk I-am-Erk merged commit 15b95a2 into CleverRaven:master Apr 4, 2024
24 checks passed
@GuardianDll GuardianDll deleted the itemgroups branch April 4, 2024 06:16
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: No Hope Relating to the mod No Hope Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants