-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
city_sizes restriction for city buildings #72815
Merged
Maleclypse
merged 5 commits into
CleverRaven:master
from
Procyonae:CitySizesRestrictionForCityBuildings
Apr 16, 2024
Merged
city_sizes restriction for city buildings #72815
Maleclypse
merged 5 commits into
CleverRaven:master
from
Procyonae:CitySizesRestrictionForCityBuildings
Apr 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
[C++]
Changes (can be) made in C++. Previously named `Code`
<Bugfix>
This is a fix for a bug (or closes open issue)
Game: Balance
Balancing of (existing) in-game features.
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Apr 3, 2024
Nice work Procyonae. What sort of tagging will be needed for the overmap locations themselves? Stadiums for example. |
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Apr 3, 2024
The Cataclysm-DDA/data/json/overmap/multitile_city_buildings.json Lines 3410 to 3471 in 8b4c779
|
ooh. I was going to do this but I'm quite okay that I don't have to. |
This was referenced Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
<Bugfix>
This is a fix for a bug (or closes open issue)
[C++]
Changes (can be) made in C++. Previously named `Code`
Game: Balance
Balancing of (existing) in-game features.
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Balance "City buildings are restricted to spawn in (more) appropriately sized cities"
Purpose of change
Addresses #72795 but that issue has interesting discussion on close future changes so I'd rather keep it open for now
Describe the solution
Allows
city_sizes
to be used withcity_building
specialsAdds usage to some existing buildings. Wants to be expanded on in future and the numbers used tweaked after more playtesting, currently the min sizes are very forgiving based on even the larger ingame "cities" at base urbanity being small in general. Weights of now restricted buildings might also want buffing. Some buildings could do with lower/higher density versions adding so city sizes that don't make sense for one kind still have good variety.
I were going to update documentation but can't even find any saying this field didn't work for city specials before
Describe alternatives you've considered
Doing this sooner
Originally I were going to include houses in this but I think they'd be better dealt with by splitting the houses "zone" into low/medium/high density and restricting their placement both on how central the placement is compared to the city centre and edge and the raw size. I'll add this in a follow up PR. This PR is better for specific building restrictions.
Not decided what to do with shops yet, I like the idea of districts discussed in #72795 but with how cities place currently that wouldn't be easy to add in a way that looks good, specialised streets could be quite doable tho.
Testing
Made
mall
spawn very frequently but only in size >= 12 cities.Expected outcome.
The overmap coverage test might not like this, will run locally a bunch of times
Additional context