Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Add pseudo tool to nether crystal outcroppings, add that tool as a possibility to contemplation recipes #72794

Merged

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Apr 2, 2024

Summary

Mods "[MoM] Add pseudo tool to nether crystal outcroppings, add that tool as a possibility to contemplation recipes"

Purpose of change

If you can meditate using a matrix crystal as a focus, should you be able to meditate among a cluster of black nether crystal? I think you should.

Does this have the possibility to lead to some...odd outcomes if you're unlucky? It might.

Describe the solution

Add a pseudo-tool to nether crystal outcroppings and add that pseudo-tool in as a possible tool for contemplation recipes.

Also add a recurring EoC that checks whether you're hanging out at a crystal cluster for long periods of time (done by the recurring EoC firing off another EoC that checks if you're still there) and can give you the Observed effect, or if you do have the Observed effect, cause some shenanigans (shenanigans to be determined).

Describe alternatives you've considered

Testing

Meditation at crystal clusters works. The EoC to check if you're near a cluster for a longer period of time also works and can give you the Observed effect. At the moment, I've only applied a single shenanigan (hearing sounds)--future PRs can expand these the way Nether Attunement is being expanded.

Most of the diff is splitting off Observed effects into their own file.

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft April 2, 2024 16:55
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mods: Mind Over Matter json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 2, 2024
@MNG-cataclysm
Copy link
Contributor

Maybe the shenanigans in question could simply be some mid to high-level Nether Attunement affects? I'd be simple enough to hook together the two effects.

@Standing-Storm
Copy link
Contributor Author

I had the idea for some separate conditions to give Observed its own identity since right now it only gives you bad dreams (hearing voices, sleepwalking, hallucinations, etc), so some of that might get implemented here.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 2, 2024
@github-actions github-actions bot added the EOC: Effects On Condition Anything concerning Effects On Condition label Apr 11, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review April 11, 2024 22:20
@github-actions github-actions bot added the Lore Game lore, in-game communication. Also the Lore tab. label Apr 11, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • You hear a single loud foostep behind you.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 11, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 12, 2024
@Maleclypse Maleclypse merged commit 14fd9ea into CleverRaven:master Apr 16, 2024
23 of 24 checks passed
@Standing-Storm Standing-Storm deleted the crystal-cluster-pseudo-tool branch April 16, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Lore Game lore, in-game communication. Also the Lore tab. Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants