Fix food fun reduction test not actually having any reduction #72783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
"fun_for_food_eaten_too_often" did not actually test anything useful. It checked if a scaling penalty was applied, but the penalty was 0.
Describe the solution
Actually check to make sure the penalty exists.
Pad the test with some more sanity checking to make sure we're doing math that makes sense.
Use a copy of the test item for the test data mod to ensure this sort of shenanigans does not occur again.
Describe alternatives you've considered
I didn't even know we had a defineable "monotony_penalty", it seems nothing actually uses a manual definition.
Kind of wanted to go muck with it and make it better across the board, but my time is due for 0.H right now.
Testing
Test passes locally
Additional context
Also updated docs to explain when monotony doesn't apply, instead of just hiding it in the item factory.