Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"gathering sights" should be "gathering sites" #72757

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

abadams
Copy link
Contributor

@abadams abadams commented Apr 1, 2024

Summary

Bugfixes " 'gathering sights' should be 'gathering sites' "

Purpose of change

One of the starting scenarios refers to "gathering sights". I stared at it uncomprehending for a few seconds before realizing it was likely supposed to be "gathering sites". Not sure if this counts as a bug-fix, but it seemed like the closest-fit category.

Describe the solution

Correct the word choice in the json and the translation files.

Describe alternatives you've considered

Testing

Rebuilt from scratch, then selected that scenario in new game to make sure the fix was in the right place.

Additional context

Copy link
Contributor

github-actions bot commented Apr 1, 2024

It appears you modified a .po or .pot file. These translation files are automatically generated, pushed to, and pulled from Transifex, and should not be modified otherwise. If these changes are intended, please add Translation file changes are intended to the PR body.

@github-actions github-actions bot added Translation I18n [JSON] Changes (can be) made in JSON Scenarios New Scenarios, balancing, bugs with scenarios <Bugfix> This is a fix for a bug (or closes open issue) new contributor labels Apr 1, 2024
@abadams
Copy link
Contributor Author

abadams commented Apr 1, 2024

Actually I'm not clear on whether or not I was supposed to keep the translation file in sync with the json. LMK what I should do.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 1, 2024
@Uwuewsky
Copy link
Contributor

Uwuewsky commented Apr 1, 2024

Actually I'm not clear on whether or not I was supposed to keep the translation file in sync with the json.

No, you only need to change the line in json.

I think now you need revert the changes in translation files.

@abadams
Copy link
Contributor Author

abadams commented Apr 1, 2024

Actually I'm not clear on whether or not I was supposed to keep the translation file in sync with the json.

No, you only need to change the line in json.

I think now you need revert the changes in translation files.

Done, thanks.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 2, 2024
@I-am-Erk I-am-Erk merged commit 55f012c into CleverRaven:master Apr 4, 2024
21 of 25 checks passed
@I-am-Erk
Copy link
Member

I-am-Erk commented Apr 4, 2024

In the future for stuff like this, you can just put "none" as the summary :)makes our job sorting the changelog a bit easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions new contributor Scenarios New Scenarios, balancing, bugs with scenarios Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants