Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mics repair kit #72751

Closed
wants to merge 2 commits into from
Closed

fix mics repair kit #72751

wants to merge 2 commits into from

Conversation

GuardianDll
Copy link
Member

Summary

Bugfixes "mics repair kit works again"

Purpose of change

Fix #71090
Closes #72554

Describe the solution

Apply Renech solution, fix itemgroups problems that was caused by it

Testing

Compiled, found roll with duct tape, reloaded mics repair kit, repaired a broom
image

image

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Vehicles Vehicles, parts, mechanics & interactions Spawn Creatures, items, vehicles, locations appearing on map Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Aftershock Anything to do with the Aftershock mod Items: Containers Things that hold other things labels Mar 31, 2024
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 31, 2024
@mqrause
Copy link
Contributor

mqrause commented Mar 31, 2024

Please make sure all the non-repair kit uses of duct tape (and other things coming in cardboard rolls) still work as expected.

@GuardianDll GuardianDll marked this pull request as draft March 31, 2024 15:13
@GuardianDll
Copy link
Member Author

They do not
image
image
fuck

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 31, 2024
@KHeket
Copy link
Contributor

KHeket commented Apr 1, 2024

Maybe remove the reloading mechanic from sewkits, mics repair kits and others and just make them use nearby resources like it makes when you craft
Because its unrealistic, that you can "reload" needle or mics repair kit. You can insert duct tape roll in the kit, and you cant insert thread into needs, and threads are also for now counted by pieces
The best way for me to implement it is:

  1. Activate mics reapair kit/sewing kit/needle
  2. Choose, which material you want to use. Duct tape/thread/sinew/heavy duty thread etc
  3. You are repairing items with this kind of resource

This way will be also much more easier for the future items

@GuardianDll
Copy link
Member Author

it is something desired, except we don't want the need of any kits or tools to open the menu, re:#64528
but it's tad bigger than eeh three lines of code

@GuardianDll
Copy link
Member Author

GuardianDll commented Apr 8, 2024 •
edited
Loading

@RenechCDDA do you happen to know a solution for this one, or i should close it?
Unless if having container field stripped from duct tape is desired, then i'll just remove code changes and rephrase a PR body

@KHeket KHeket mentioned this pull request Apr 8, 2024
Closed
@KHeket
Copy link
Contributor

KHeket commented Apr 9, 2024

Check pls this two good ideas to make kits and needles work more player and contributor friendly, more realistic, and this ideas is much more easy to realize, than to fix this bug
#72899
#72774

@GuardianDll
Copy link
Member Author

GuardianDll commented Apr 9, 2024 •
edited
Loading

> making brand new UI that hold and handle all repair stuff
> easier than two lines of code and bunch of json copypaste
is it a better approach? sure. is it easier? hell no
(no offense)

@AnotherSeawhite
Copy link
Contributor

I'm honestly not sure if there's an 'easy' fix for this bug.

@RenechCDDA
Copy link
Member

@RenechCDDA do you happen to know a solution for this one, or i should close it? Unless if having container field stripped from duct tape is desired, then i'll just remove code changes and rephrase a PR body

I don't have any recommendations for you right now

@GuardianDll
Copy link
Member Author

closed in favor of #72751, unless removing container field from duct tape item definition is desired, then i'll reopen and scrap off the tool changes and left only itemgroup stuff

@GuardianDll GuardianDll deleted the duct_tape_fix branch April 19, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Candlebury John-Candlebury Awaiting requested review from John-Candlebury

@Maleclypse Maleclypse Awaiting requested review from Maleclypse

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies NPC / Factions NPCs, AI, Speech, Factions, Ownership Spawn Creatures, items, vehicles, locations appearing on map Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to reload Misc repair kit
5 participants
@GuardianDll @mqrause @KHeket @AnotherSeawhite @RenechCDDA