Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract field bash and effect apply text #72745

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

Uwuewsky
Copy link
Contributor

Summary

None

Purpose of change

Some text was not available for translation.
a
b

Describe the solution

Change the script to extract these lines.
I also replaced the text describing the effect of irritation from smoke with another existing one, all neighboring effects do the same

Describe alternatives you've considered

Testing

1

#. ~ Bashing message of fields "cobwebs", "webs", "thick webs"
#. ~ Bashing message of fields "thin cobwebs", "thin webs"
#: data/json/field_type.json
msgid "You brush aside some webs."
msgstr ""

Additional context

@github-actions github-actions bot added Translation I18n [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [Python] Code made in Python labels Mar 31, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • You shouldn't have taken this many pills. Your skin flushes and your nerves feel like they are on fire.
  • Your heartbeat doesn't feel normal. Why on earth did you take more of these pills?

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 31, 2024
@Karol1223
Copy link
Contributor

Karol1223 commented Mar 31, 2024

The string edit here is to make it the same as is for other similar effects, correct? Wouldn't it be better to switch the other effects' strings to this one's instead?

It sounds like a regression to me. The new string sounds less english, though since I am not a native speaker I may just be confused by something that's not actually a problem.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 31, 2024
@Uwuewsky
Copy link
Contributor Author

Change it to Your eyes are watering.? yeah, sure, that other string also sound strange to me. i'll take it with flake8 complains.

@Uwuewsky Uwuewsky marked this pull request as draft March 31, 2024 14:47
@Uwuewsky Uwuewsky marked this pull request as ready for review April 1, 2024 01:08
@dseguin dseguin merged commit 7e7089f into CleverRaven:master Apr 9, 2024
28 of 38 checks passed
@Uwuewsky Uwuewsky deleted the tweak-parser branch June 15, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Python] Code made in Python Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants